-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Non-selfexhausting Drain #2369
Conversation
Another possible alternative: a method on the Drain type like |
This RFC came up when the libs team discussed the unstable We’d like to see experimentation to attempt to generalize into a smaller API surface various combinations of draining:
Possibilities might include "overloading" a method by making it generic, or a builder pattern. (One constraint is that the This would likely be in a new RFC rather than taking this one as-is: @rfcbot fcp postpone |
Team member @SimonSapin has proposed to postpone this. The next step is review by the rest of the tagged teams: No concerns currently listed. Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
The final comment period is now complete. |
This RFC is now postponed per the review above. Thanks to @Emerentius! |
Rendered
Add
*_nonexhausting()
variants for everydrain()
that do not eagerly consume residual items on drop of theDrainNonexhausting
struct.One of two RFCs for splitting the functionality of
drain
into two orthogonal APIs.Other RFC: #2370